Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set application_name for internal connections to computes #8047

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Set application_name for internal connections to computes #8047

merged 1 commit into from
Jun 13, 2024

Conversation

tristan957
Copy link
Member

This will help when analyzing the origins of connections to a compute like in 0.

@tristan957
Copy link
Member Author

Is anyone aware of any other places we might be creating internal connections?

@tristan957
Copy link
Member Author

Would it be useful to add a neon/ prefix for these application names? Could help create better SQL queries.

@save-buffer
Copy link
Contributor

We create connections in compute_ctl. We have a monitor that connects every so often

@sharnoff
Copy link
Member

We should also set the application name for vm-monitor connections:

neon/compute_tools/src/bin/compute_ctl.rs

Lines 734 to 741 in d25f7e3

.arg(
Arg::new("filecache-connstr")
.long("filecache-connstr")
.default_value(
"host=localhost port=5432 dbname=postgres user=cloud_admin sslmode=disable",
)
.value_name("FILECACHE_CONNSTR"),
)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 13, 2024 •
edited
Loading

3216 tests run: 3074 passed, 0 failed, 142 skipped (full report)

Flaky tests (3)

Postgres 16

  • test_storage_controller_smoke: debug
  • test_vm_bit_clear_on_heap_lock_blackbox: release

Postgres 14

  • test_storage_controller_smoke: debug

Code coverage* (full report)

  • functions: 31.5% (6634 of 21060 functions)
  • lines: 48.6% (51623 of 106255 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
2884eb0 at 2024-06-13T17:19:17.920Z :recycle:

@tristan957
Set application_name for internal connections to computes
2884eb0 
This will help when analyzing the origins of connections to a compute
like in [0].

[0]: neondatabase/cloud#14247
@tristan957 tristan957 force-pushed the tristan957/application_name branch from 26815d5 to 2884eb0 Compare June 13, 2024 16:33
@tristan957 tristan957 requested review from a team as code owners June 13, 2024 16:33
@tristan957 tristan957 requested a review from mtyazici June 13, 2024 16:33
@tristan957 tristan957 merged commit 0c3e3a8 into main Jun 13, 2024
67 of 68 checks passed
@tristan957 tristan957 deleted the tristan957/application_name branch June 13, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharnoff sharnoff sharnoff approved these changes

@save-buffer save-buffer Awaiting requested review from save-buffer

@mtyazici mtyazici Awaiting requested review from mtyazici mtyazici was automatically assigned from neondatabase/control-plane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tristan957 @save-buffer @sharnoff